Re: [RFC][PATCH 1/3] memcg: add methods to access pc->mem_cgroup

On Mon 19-03-12 14:58:00, Glauber Costa wrote:

On 03/19/2012 11:59 AM, KAMEZAWA Hiroyuki wrote:

quoted

In order to encode pc->mem_cgroup and pc->flags to be in a word,
access function to pc->mem_cgroup is required.

This patch replaces access to pc->mem_cgroup with
  pc_to_mem_cgroup(pc)          : pc->mem_cgroup
  pc_set_mem_cgroup(pc, memcg)  : pc->mem_cgroup = memcg

Following patch will remove pc->mem_cgroup.

Signed-off-by: KAMEZAWA Hiroyuki<redacted>

Kame,

I can't see a reason not to merge this patch right now, regardless of
the other ones.

 
I am not so sure about that. The patch doesn't do much on its own and
reference to the "following patch" might be confusing. Does it actually
help to rush it now?
-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic