Re: [PATCH] memcg: Free spare array to avoid memory leak
flat view
From: KAMEZAWA Hiroyuki <hidden>
Date: 2012-03-09 03:41:54
Also in:
linux-mm
On Tue, 6 Mar 2012 20:13:24 +0800 Sha Zhengju [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Sha Zhengju <redacted> When the last event is unregistered, there is no need to keep the spare array anymore. So free it to avoid memory leak. Signed-off-by: Sha Zhengju <redacted> --- mm/memcontrol.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 22d94f5..3c09a84 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c@@ -4412,6 +4412,12 @@ static void mem_cgroup_usage_unregister_event(struct cgroup *cgrp, swap_buffers: /* Swap primary and spare array */ thresholds->spare = thresholds->primary; + /* If all events are unregistered, free the spare array */ + if (!new) { + kfree(thresholds->spare); + thresholds->spare = NULL; + } +
Could you clear thresholds->primary ? I don't like a pointer points to freed memory. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>