On Mon, 19 Mar 2012 11:56:25 +0900, KAMEZAWA Hiroyuki [off-list ref] wrote:

(2012/03/17 2:39), Aneesh Kumar K.V wrote:

quoted

From: "Aneesh Kumar K.V" <redacted>

This add control files for hugetlbfs in memcg

Signed-off-by: Aneesh Kumar K.V <redacted>

I have a question. When a user does

	1. create memory cgroup as
		/cgroup/A
	2. insmod hugetlb.ko
	3. ls /cgroup/A

and then, files can be shown ? Don't we have any problem at rmdir A ?

I'm sorry if hugetlb never be used as module.

HUGETLBFS cannot be build as kernel module

a comment below.

quoted

---
 include/linux/hugetlb.h    |   17 +++++++++++++++
 include/linux/memcontrol.h |    7 ++++++
 mm/hugetlb.c               |   25 ++++++++++++++++++++++-
 mm/memcontrol.c            |   48 ++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 96 insertions(+), 1 deletions(-)

......

quoted

+#ifdef CONFIG_MEM_RES_CTLR_HUGETLB
+static char *mem_fmt(char *buf, unsigned long n)
+{
+	if (n >= (1UL << 30))
+		sprintf(buf, "%luGB", n >> 30);
+	else if (n >= (1UL << 20))
+		sprintf(buf, "%luMB", n >> 20);
+	else
+		sprintf(buf, "%luKB", n >> 10);
+	return buf;
+}
+
+int mem_cgroup_hugetlb_file_init(int idx)
+{

__init ? 

Added .

And... do we have guarantee that this function is called before
creating root mem cgroup even if CONFIG_HUGETLBFS=y ?

Yes. This should be called before creating root mem cgroup.

-aneesh