On 02/22/2012 12:01 PM, Glauber Costa wrote:

On 02/22/2012 04:46 AM, KAMEZAWA Hiroyuki wrote:

quoted

On Tue, 21 Feb 2012 15:34:33 +0400
Glauber Costa[off-list ref] wrote:

quoted

Move some hardcoded definitions to an enum type.

Signed-off-by: Glauber Costa<redacted>
CC: Kirill A. Shutemov<redacted>
CC: Greg Thelen<redacted>
CC: Johannes Weiner<redacted>
CC: Michal Hocko<redacted>
CC: Hiroyouki Kamezawa<redacted>
CC: Paul Turner<redacted>
CC: Frederic Weisbecker<redacted>

seems ok to me.

Acked-by: KAMEZAWA Hiroyuki<redacted>

BTW, this series is likely to go through many rounds of discussion.
This patch can be probably picked separately, if you want to.

quoted

a nitpick..

quoted

---
mm/memcontrol.c | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 6728a7a..b15a693 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c

@@ -351,9 +351,13 @@ enum charge_type {

};

/* for encoding cft->private value on file */
-#define _MEM (0)
-#define _MEMSWAP (1)
-#define _OOM_TYPE (2)
+
+enum mem_type {
+ _MEM = 0,

=0 is required ?

I believe not, but I always liked to use it to be 100 % explicit.
Personal taste... Can change it, if this is a big deal.

Kame, would you like me to send this cleanup without the = 0 ?