Re: [PATCH 1/7] small cleanup for memcontrol.c
From: KAMEZAWA Hiroyuki <hidden>
Date: 2012-02-22 00:48:00
Also in:
linux-mm
On Tue, 21 Feb 2012 15:34:33 +0400 Glauber Costa [off-list ref] wrote:
Move some hardcoded definitions to an enum type. Signed-off-by: Glauber Costa <redacted> CC: Kirill A. Shutemov <redacted> CC: Greg Thelen <redacted> CC: Johannes Weiner <redacted> CC: Michal Hocko <redacted> CC: Hiroyouki Kamezawa <redacted> CC: Paul Turner <redacted> CC: Frederic Weisbecker <redacted>
seems ok to me. Acked-by: KAMEZAWA Hiroyuki <redacted> a nitpick..
quoted hunk ↗ jump to hunk
--- mm/memcontrol.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-)diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 6728a7a..b15a693 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c@@ -351,9 +351,13 @@ enum charge_type { }; /* for encoding cft->private value on file */ -#define _MEM (0) -#define _MEMSWAP (1) -#define _OOM_TYPE (2) + +enum mem_type { + _MEM = 0,
=0 is required ?
+ _MEMSWAP, + _OOM_TYPE, +}; + #define MEMFILE_PRIVATE(x, val) (((x) << 16) | (val)) #define MEMFILE_TYPE(val) (((val) >> 16) & 0xffff) #define MEMFILE_ATTR(val) ((val) & 0xffff) -- 1.7.7.6
-- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>