On 8/9/21 4:24 PM, Jussi Maki wrote:
[...]

quoted

quoted

+       if (!test__start_subtest("xdp_bonding_redirect_multi"))
+               test_xdp_bonding_redirect_multi(&skeletons);
+
+out:
+       xdp_dummy__destroy(skeletons.xdp_dummy);
+       xdp_tx__destroy(skeletons.xdp_tx);
+       xdp_redirect_multi_kern__destroy(skeletons.xdp_redirect_multi_kern);
+
+       libbpf_set_print(old_print_fn);
+       if (root_netns_fd)

technically, fd could be 0, so for fds we have if (fd >= 0)
everywhere. Also, if open() above fails, root_netns_fd will be -1 and
you'll still attempt to close it.

Good catch. Daniel, could you fix this when applying to be "if
(root_netns_fd >= 0)"?

Yep, done now, I had to rebase due to 220ade77452c ("bonding: 3ad: fix the concurrency
between __bond_release_one() and bond_3ad_state_machine_handler()") which this series
here didn't take into account. Please double check.

Thanks everyone,
Daniel