Re: [PATCH v6 06/10] iommufd: Add iommufd fault object

On 6/12/24 9:25 PM, Jason Gunthorpe wrote:

On Sat, Jun 08, 2024 at 05:58:34PM +0800, Baolu Lu wrote:

quoted

quoted

quoted

+static int iommufd_fault_fops_release(struct inode *inode, struct file *filep)
+{
+	struct iommufd_fault *fault = filep->private_data;
+
+	iommufd_ctx_put(fault->ictx);
+	refcount_dec(&fault->obj.users);
+	return 0;

This is in the wrong order, dec users before ctx_put.

Done.

Best regards,
baolu