Thread (13 messages) 13 messages, 3 authors, 2024-03-26

Re: [PATCH vhost v5 1/6] virtio_balloon: remove the dependence where names[] is null

From: Jason Wang <hidden>
Date: 2024-03-26 04:14:31
Also in: kvm, linux-remoteproc, linux-s390, linux-um, platform-driver-x86

On Mon, Mar 25, 2024 at 5:04 PM Xuan Zhuo [off-list ref] wrote:
Currently, the init_vqs function within the virtio_balloon driver relies
on the condition that certain names array entries are null in order to
skip the initialization of some virtual queues (vqs).
If there's a respin I would add something like:

1) the virtqueue index is contiguous for all the existing devices.
2) the current behaviour of virtio-balloon device is different from
what is described in the spec 1.0-1.2
3) there's no functional changes and explain why
This behavior is
unique to this part of the codebase. In an upcoming commit, we plan to
eliminate this dependency by removing the function entirely. Therefore,
with this change, we are ensuring that the virtio_balloon no longer
depends on the aforementioned function.

Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
With the above tweak.

Acked-by: Jason Wang <redacted>

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help