Re: [PATCH] virtiofs: don't mark virtio_fs_sysfs_exit as __exit
From: Stefan Hajnoczi <hidden>
Date: 2024-02-28 22:23:27
Also in:
linux-fsdevel, lkml
On Wed, 28 Feb 2024 at 16:47, Arnd Bergmann [off-list ref] wrote:
From: Arnd Bergmann <arnd@arndb.de>
Calling an __exit function from an __init function is not allowed
and will result in undefined behavior when the code is built-in:
WARNING: modpost: vmlinux: section mismatch in reference: virtio_fs_init+0x50 (section: .init.text) -> virtio_fs_sysfs_exit (section: .exit.text)
Remove the incorrect annotation.
Fixes: a8f62f50b4e4 ("virtiofs: export filesystem tags through sysfs")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/fuse/virtio_fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)Thanks, Arnd. Please see the duplicate patch that Miklos applied: https://lore.kernel.org/linux-fsdevel/CAJfpegsjcZ-dnZYft3B5GBGCntmDR6R1n8PM5YCLmW9FJy1DEw@mail.gmail.com/T/#t (local) Stefan
quoted hunk ↗ jump to hunk
diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c index 3a7dd48b534f..36d87dd3cb48 100644 --- a/fs/fuse/virtio_fs.c +++ b/fs/fuse/virtio_fs.c@@ -1595,7 +1595,7 @@ static int __init virtio_fs_sysfs_init(void) return 0; } -static void __exit virtio_fs_sysfs_exit(void) +static void virtio_fs_sysfs_exit(void) { kset_unregister(virtio_fs_kset); virtio_fs_kset = NULL; --2.39.2