On 9/7/2023 1:41 PM, Si-Wei Liu wrote:

Hi David,

Why this patch doesn't get picked in the last 4 months? Maybe the
subject is not clear, but this is an iproute2 patch. Would it be
possible to merge at your earliest convenience?

PS, adding my R-b to the patch.

Maybe I aimed this at the wrong person?  I see that Stephen just 
announced the latest iproute2
https://lore.kernel.org/netdev/20230906093918.394a1b1d@hermes.local/ (local)

I probably also should have made sure that "iproute2" was in the subject 
prefix.

Hi Stephen, perhaps you can help with this?

Thanks,
sln

Thanks,
-Siwei


On Sat, May 13, 2023 at 12:42 AM Shannon Nelson [off-list ref]
wrote:
 >
 > From: Allen Hubbe [off-list ref]
 >
 > Consume the parameter to device_features when parsing command line
 > options.  Otherwise the parameter may be used again as an option name.
 >
 >  # vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55
 >  Unknown option "0xdeadbeef"
 >
 > Fixes: a4442ce58ebb ("vdpa: allow provisioning device features")
 > Signed-off-by: Allen Hubbe [off-list ref]
 > Reviewed-by: Shannon Nelson [off-list ref]

Reviewed-by: Si-Wei Liu <redacted>

 > ---
 >  vdpa/vdpa.c | 2 ++
 >  1 file changed, 2 insertions(+)
 >
 > diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c
 > index 27647d73d498..8a2fca8647b6 100644
 > --- a/vdpa/vdpa.c
 > +++ b/vdpa/vdpa.c
 > @@ -353,6 +353,8 @@ static int vdpa_argv_parse(struct vdpa *vdpa, int
argc, char **argv,
 > &opts->device_features);
 >                         if (err)
 >                                 return err;
 > +
 > +                       NEXT_ARG_FWD();
 >                         o_found |= VDPA_OPT_VDEV_FEATURES;
 >                 } else {
 >                         fprintf(stderr, "Unknown option \"%s\"\n",
*argv);
 > --
 > 2.17.1
 >

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization