Re: [PATCH 01/23] block: factor out a bvec_set_page helper
From: Christoph Hellwig <hch@lst.de>
Date: 2023-01-31 13:45:36
Also in:
ceph-devel, io-uring, kvm, linux-block, linux-cifs, linux-fsdevel, linux-mm, linux-nfs, linux-nvme, linux-scsi, netdev, target-devel
On Mon, Jan 30, 2023 at 09:09:23AM -0800, Bart Van Assche wrote:
Has it been considered to use structure assignment instead of introducing
bvec_set_page(), e.g. as follows?
bip->bip_vec[bip->bip_vcnt] = (struct bio_vec) {
.bv_page = page, .bv_len = len, .bv_offset = offset };Unless it's hidden behind a macro it doesn't solve the problem of abstraction away the layout. I'm also find it less readable. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization