Thread (1 message) flat view 1 message, 1 author, 2023-01-21

Re: [PATCH RFC 1/3] vsock: support sockmap

From: Cong Wang <hidden>
Date: 2023-01-21 19:23:04
Also in: bpf, kvm, linux-kselftest, lkml, netdev

On Wed, Jan 18, 2023 at 12:27:39PM -0800, Bobby Eshleman wrote:
+static int vsock_read_skb(struct sock *sk, skb_read_actor_t read_actor)
+{
+	struct vsock_sock *vsk = vsock_sk(sk);
+
+	if (!vsk->transport)
+		return -ENODEV;
+
+	if (!vsk->transport->read_skb)
+		return -EOPNOTSUPP;
Can we move these two checks to sockmap update path? It would make
vsock_read_skb() faster.
+
+	return vsk->transport->read_skb(vsk, read_actor);
+}
Essentially can be just this one line.

Thanks.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help