Re: [RESEND PATCH v5 1/1] docs: driver-api: virtio: virtio on Linux
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2022-12-19 06:21:18
Also in:
linux-doc
On Tue, Oct 11, 2022 at 10:46:43AM +0200, Ricardo Cañuelo wrote:
quoted
quoted
+It's at this stage that the virtqueues will be allocated and configured +by calling the appropriate ``virtio_find`` helper function, such as +virtio_find_single_vq() or virtio_find_vqs(), which will end up +calling a transport-specific ``find_vqs`` method. +Looks like the wording at the beginning confuses me, so better say: ---- >8 ----diff --git a/Documentation/driver-api/virtio/virtio.rst b/Documentation/driver-api/virtio/virtio.rst index 07fd2d7c51e689..7947b4ca690efd 100644 --- a/Documentation/driver-api/virtio/virtio.rst +++ b/Documentation/driver-api/virtio/virtio.rst@@ -123,10 +123,10 @@ When the device is registered to the virtio bus the kernel will look for a driver in the bus that can handle the device and call that driver's ``probe`` method.I think this is a matter of style as well, maybe a native speaker can pitch in about the correctness of it. Cheers, Ricardo
I think I agree with this comment. This seems minor enough so I applied the patch for now. Bagas would you like to post your suggestion as a patch on top? Would be appreciated. Thanks! -- MST _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization