Re: [PATCH v2] virtio-blk: Avoid use-after-free on suspend/resume
From: Jens Axboe <axboe@kernel.dk>
Date: 2022-08-11 23:04:09
Also in:
linux-block, lkml
On 8/10/22 10:09 AM, Shigeru Yoshida wrote:
+static inline struct virtio_blk_vq *get_virtio_blk_vq(struct blk_mq_hw_ctx *hctx)
+{
+ struct virtio_blk *vblk = hctx->queue->queuedata;
+ struct virtio_blk_vq *vq = &vblk->vqs[hctx->queue_num];
+
+ return vq;
+}
Would probably be cleaner as:
static struct virtio_blk_vq *get_virtio_blk_vq(struct blk_mq_hw_ctx *hctx)
{
struct virtio_blk *vblk = hctx->queue->queuedata;
return &vblk->vqs[hctx->queue_num];
}
dropping the 'vq' variable, and also dropping the inline as the compiler
will work that out anyway.
Apart from that minor nit, looks good to me.
--
Jens Axboe
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization