Re: [RFC PATCH v3 9/9] vsock_test: POLLIN + SO_RCVLOWAT test
From: Stefano Garzarella <sgarzare@redhat.com>
Date: 2022-08-08 11:10:55
Also in:
kvm, linux-hyperv, lkml, netdev
On Wed, Aug 03, 2022 at 02:07:58PM +0000, Arseniy Krasnov wrote:
quoted hunk
This adds test to check,that when poll() returns POLLIN,POLLRDNORM bits, next read call won't block. Signed-off-by: Arseniy Krasnov <redacted> --- tools/testing/vsock/vsock_test.c | 107 +++++++++++++++++++++++++++++++ 1 file changed, 107 insertions(+)diff --git a/tools/testing/vsock/vsock_test.c b/tools/testing/vsock/vsock_test.c index dc577461afc2..920dc5d5d979 100644 --- a/tools/testing/vsock/vsock_test.c +++ b/tools/testing/vsock/vsock_test.c@@ -18,6 +18,7 @@#include <sys/socket.h> #include <time.h> #include <sys/mman.h> +#include <poll.h> #include "timeout.h" #include "control.h"@@ -596,6 +597,107 @@ static void test_seqpacket_invalid_rec_buffer_server(const struct test_opts *optclose(fd); } +static void test_stream_poll_rcvlowat_server(const struct test_opts *opts) +{ +#define RCVLOWAT_BUF_SIZE 128
Since we use this macro on both server and client functions, I suggest to move this define outside the function. Other than that the test LGTM. I also ran it and everything is fine :-) thanks for adding it! Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization