Re: [PATCH 14/36] cpuidle: Fix rcu_idle_*() usage
From: Mark Rutland <mark.rutland@arm.com>
Date: 2022-06-14 12:43:04
Also in:
linux-acpi, linux-alpha, linux-arch, linux-arm-msm, linux-clk, linux-m68k, linux-mips, linux-omap, linux-perf-users, linux-pm, linux-riscv, linux-s390, linux-sh, linux-tegra, linux-um, linuxppc-dev, lkml, rcu, sparclinux, xen-devel
On Wed, Jun 08, 2022 at 04:27:37PM +0200, Peter Zijlstra wrote:
quoted hunk ↗ jump to hunk
--- a/kernel/time/tick-broadcast.c +++ b/kernel/time/tick-broadcast.c@@ -622,9 +622,13 @@ struct cpumask *tick_get_broadcast_onesh * to avoid a deep idle transition as we are about to get the * broadcast IPI right away. */ -int tick_check_broadcast_expired(void) +noinstr int tick_check_broadcast_expired(void) { +#ifdef _ASM_GENERIC_BITOPS_INSTRUMENTED_NON_ATOMIC_H + return arch_test_bit(smp_processor_id(), cpumask_bits(tick_broadcast_force_mask)); +#else return cpumask_test_cpu(smp_processor_id(), tick_broadcast_force_mask); +#endif }
This is somewhat not-ideal. :/ Could we unconditionally do the arch_test_bit() variant, with a comment, or does that not exist in some cases? Thanks, Mark. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization