Re: [PATCH] virtio: Directly use ida_alloc()/free()
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2022-05-27 10:26:15
Also in:
lkml
On Fri, May 27, 2022 at 07:33:02AM +0000, keliu wrote:
Use ida_alloc()/ida_free() instead of deprecated ida_simple_get()/ida_simple_remove() . Signed-off-by: keliu <redacted>
Please Cc people that commented on the original patch. thanks!
quoted hunk
--- drivers/virtio/virtio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 22f15f444f75..143f94652306 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c@@ -413,7 +413,7 @@ int register_virtio_device(struct virtio_device *dev) device_initialize(&dev->dev); /* Assign a unique device index and hence name. */ - err = ida_simple_get(&virtio_index_ida, 0, 0, GFP_KERNEL); + err = ida_alloc(&virtio_index_ida, GFP_KERNEL); if (err < 0) goto out;@@ -451,7 +451,7 @@ int register_virtio_device(struct virtio_device *dev) out_of_node_put: of_node_put(dev->dev.of_node); out_ida_remove: - ida_simple_remove(&virtio_index_ida, dev->index); + ida_free(&virtio_index_ida, dev->index); out: virtio_add_status(dev, VIRTIO_CONFIG_S_FAILED); return err;@@ -469,7 +469,7 @@ void unregister_virtio_device(struct virtio_device *dev) int index = dev->index; /* save for after device release */ device_unregister(&dev->dev); - ida_simple_remove(&virtio_index_ida, index); + ida_free(&virtio_index_ida, index); } EXPORT_SYMBOL_GPL(unregister_virtio_device);-- 2.25.1
_______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization