Re: [PATCH v2] x86/vmware: use unsigned integer for shifting
From: Thomas Gleixner <hidden>
Date: 2022-05-20 23:26:24
Also in:
lkml
On Fri, May 20 2022 at 19:39, Shreenidhi Shedi wrote:
From: Shreenidhi Shedi <redacted> From: Shreenidhi Shedi <redacted>
Can you please decide which of your personalities wrote that patch?
Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. Using unsigned is better option for this.
Better option? There are no options. It's either correct or not. Please be precise and technical in your wording.
Fixes: 4cca6ea04d31 ("x86/apic: Allow x2apic without IR on VMware platform")
Signed-off-by: Shreenidhi Shedi <redacted>Please keep the tags together. This extra new line is pointless and makes the maintainer do extra work to remove it. Documentation/process/* has all the relevant directives for you. Following them is not an option. It's mandatory.
quoted hunk
@@ -476,8 +477,8 @@ static bool __init vmware_legacy_x2apic_available(void) { uint32_t eax, ebx, ecx, edx; VMWARE_CMD(GETVCPU_INFO, eax, ebx, ecx, edx); - return (eax & (1 << VMWARE_CMD_VCPU_RESERVED)) == 0 && - (eax & (1 << VMWARE_CMD_LEGACY_X2APIC)) != 0; + return !(eax & BIT(VMWARE_CMD_VCPU_RESERVED)) && + (eax & BIT(VMWARE_CMD_LEGACY_X2APIC))
Testing your changes before submission is not optional either. How is
this supposed to compile?
Thanks,
tglx
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization