Re: [PATCH v3] arm64: paravirt: Use RCU read locks to guard stolen_time
flat view
From: Srivatsa S. Bhat <hidden>
Date: 2022-05-17 16:48:18
Also in:
linux-arm-kernel, lkml
On 5/17/22 1:54 AM, Will Deacon wrote:
On Fri, May 13, 2022 at 04:32:53PM -0700, Srivatsa S. Bhat wrote:quoted
On 5/13/22 10:46 AM, Elliot Berman wrote:quoted
From: Prakruthi Deepak Heragu <redacted>
[...]
quoted
quoted
static int stolen_time_cpu_down_prepare(unsigned int cpu) { + struct pvclock_vcpu_stolen_time *kaddr = NULL; struct pv_time_stolen_time_region *reg; reg = this_cpu_ptr(&stolen_time_region); if (!reg->kaddr) return 0; - memunmap(reg->kaddr); - memset(reg, 0, sizeof(*reg)); + kaddr = rcu_replace_pointer(reg->kaddr, NULL, true); + synchronize_rcu(); + memunmap(kaddr);The original code used to memset the stolen time region, but this patch seems to drop it. Was that change intentional?'struct pv_time_stolen_time_region' only has one field ('kaddr'), which we're now clearing with rcu_replace_pointer() so the memset doesn't make sense.
Ah right, never mind :) Thank you! Regards, Srivatsa _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization