Re: [PATCH] virtio/virtio_pci_legacy_dev: ensure the correct return value
From: Jason Wang <hidden>
Date: 2021-12-23 05:59:04
Also in:
lkml
On Wed, Dec 22, 2021 at 7:21 PM Peng Hao [off-list ref] wrote:
When pci_iomap return NULL, the return value is zero. Signed-off-by: Peng Hao <redacted> ---
Acked-by: Jason Wang <redacted>
quoted hunk
drivers/virtio/virtio_pci_legacy_dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/drivers/virtio/virtio_pci_legacy_dev.c b/drivers/virtio/virtio_pci_legacy_dev.c index 9b97680dd02b..677d1f68bc9b 100644 --- a/drivers/virtio/virtio_pci_legacy_dev.c +++ b/drivers/virtio/virtio_pci_legacy_dev.c@@ -45,8 +45,10 @@ int vp_legacy_probe(struct virtio_pci_legacy_device *ldev) return rc; ldev->ioaddr = pci_iomap(pci_dev, 0, 0); - if (!ldev->ioaddr) + if (!ldev->ioaddr) { + rc = -EIO; goto err_iomap; + } ldev->isr = ldev->ioaddr + VIRTIO_PCI_ISR; --2.27.0
_______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization