Thread (1 message) 1 message, 1 author, 2021-12-22

Re: [PATCH v5 09/13] vdpa/mlx5: Restore cur_num_vqs in case of failure in change_num_qps()

From: Si-Wei Liu <hidden>
Date: 2021-12-22 02:02:03


On 12/21/2021 9:20 AM, Eli Cohen wrote:
Restore ndev->cur_num_vqs to the original value in case change_num_qps()
fails.

Fixes: 52893733f2c5 ("vdpa/mlx5: Add multiqueue support")
Acked-by: Jason Wang <redacted>
Signed-off-by: Eli Cohen <redacted>
Reviewed-by: Si-Wei Liu<redacted>
quoted hunk
---
  drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index 848eabbb1831..72ed5efbe35d 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -1536,9 +1536,11 @@ static int change_num_qps(struct mlx5_vdpa_dev *mvdev, int newqps)
  	return 0;
  
  clean_added:
-	for (--i; i >= cur_qps; --i)
+	for (--i; i >= 2 * cur_qps; --i)
  		teardown_vq(ndev, &ndev->vqs[i]);
  
+	ndev->cur_num_vqs = 2 * cur_qps;
+
  	return err;
  }
  
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help