Re: [PATCH 1/2] vdpa: Allow to configure max data virtqueues

On 12/1/2021 2:03 AM, Eli Cohen wrote:

quoted

quoted

+		if ((config.max_virtqueues - 1) & config.max_virtqueues) {
+			NL_SET_ERR_MSG_MOD(info->extack,
+					   "Must provide power of two number of virtqueues");

Why there's such limitation for the number of vDPA virtqueues? I thought the
software virtio doesn't have this limitation (power of two).

Right, the limitation comes from mlx5_vdpa. I will post a patch later to
remove that limitation.

I mean the check should not live here. Other vdpa vendor device/driver 
may not have this limitation.

-Siwei