Thread (2 messages) 2 messages, 2 authors, 2021-11-26

Re: [PATCH] vdpa: Consider device id larger than 31

flat view

From: Jason Wang <hidden>
Date: 2021-11-26 02:52:00
Also in: lkml, oe-kbuild-all

On Fri, Nov 26, 2021 at 2:09 AM Parav Pandit [off-list ref] wrote:
virtio device id value can be more than 31. Hence, use BIT_ULL in
assignment.

Fixes: 33b347503f01 ("vdpa: Define vdpa mgmt device, ops and a netlink interface")
Reported-by: kernel test robot <redacted>
Reported-by: Dan Carpenter <redacted>
Signed-off-by: Parav Pandit <redacted>
Acked-by: Jason Wang <redacted>
quoted hunk ↗ jump to hunk
---
 drivers/vdpa/vdpa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
index 7332a74a4b00..e91c71aeeddf 100644
--- a/drivers/vdpa/vdpa.c
+++ b/drivers/vdpa/vdpa.c
@@ -404,7 +404,7 @@ static int vdpa_mgmtdev_fill(const struct vdpa_mgmt_dev *mdev, struct sk_buff *m
                goto msg_err;

        while (mdev->id_table[i].device) {
-               supported_classes |= BIT(mdev->id_table[i].device);
+               supported_classes |= BIT_ULL(mdev->id_table[i].device);
                i++;
        }

--
2.26.2
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help