Re: [PATCH] net/mlx5_vdpa: Increase the limit on the number of virtuques | virtualization

(off-list ancestor, not in this archive)

On 11/25/2021 8:22 AM, Michael S. Tsirkin wrote:
On Thu, Nov 25, 2021 at 09:29:53AM +0200, Eli Cohen wrote:
On Thu, Nov 25, 2021 at 02:21:43AM -0500, Michael S. Tsirkin wrote:
On Wed, Nov 24, 2021 at 07:19:53PM +0200, Eli Cohen wrote:
Increase the limit on the maximum number of supported virtqueues to 256
to match hardware capabilities.
Hmm and are we going to have to tweak it each time new hardware/firmware
is out? Can't this be queried in some way?
I thought to make the allocation dynamic once we have support for
setting max queues through vdpa tool.
Well this will make things a bit harder to figure out then,
right now you can assume no vdpa tool support -> max 16 VQs.
The patch breaks this. Is there a motivation to up this right now,
or should we just wait a bit for vdpa tool support?
+1 on waiting for vdpa tool support.

-Siwei


In fact there's a suggestion in code to remove the limitation -
any plans to do this?
Can you be more speicifc, where?
It's right there in the patch:

   /* We will remove this limitation once mlx5_vdpa_alloc_resources()
    * provides for driver space allocation
    */
Signed-off-by: Eli Cohen <redacted>
typo in subject
What typo?
virtuques. ispell is your friend.

---
  drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index ed7a63e48335..8f2918a8efc6 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -135,7 +135,7 @@ struct mlx5_vdpa_virtqueue {
  /* We will remove this limitation once mlx5_vdpa_alloc_resources()
   * provides for driver space allocation
   */
-#define MLX5_MAX_SUPPORTED_VQS 16
+#define MLX5_MAX_SUPPORTED_VQS 256
  
  static bool is_index_valid(struct mlx5_vdpa_dev *mvdev, u16 idx)
  {
-- 
2.33.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help

Possibly related (same subject, not in this thread)