Re: [PATCH] virtio-blk: modify the value type of num in virtio_queue_rq()
From: Stefano Garzarella <sgarzare@redhat.com>
Date: 2021-11-17 09:20:25
Also in:
linux-block, lkml
Possibly related (same subject, not in this thread)
- 2021-11-24 · Re: [PATCH] virtio-blk: modify the value type of num in virtio_queue_rq() · Stefan Hajnoczi <stefanha@redhat.com>
On Wed, Nov 17, 2021 at 06:39:55AM +0000, cgel.zte@gmail.com wrote:
From: Ye Guojin <redacted> This was found by coccicheck: ./drivers/block/virtio_blk.c, 334, 14-17, WARNING Unsigned expression compared with zero num < 0
We should add the Fixes tag:
Fixes: 02746e26c39e ("virtio-blk: avoid preallocating big SGL for data")
quoted hunk
Reported-by: Zeal Robot <redacted> Signed-off-by: Ye Guojin <redacted> --- drivers/block/virtio_blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 97bf051a50ce..eed1666eff31 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c@@ -316,7 +316,7 @@ static blk_status_t virtio_queue_rq(structblk_mq_hw_ctx *hctx, struct request *req = bd->rq; struct virtblk_req *vbr = blk_mq_rq_to_pdu(req); unsigned long flags; - unsigned int num; + int num; int qid = hctx->queue_num; bool notify = false; blk_status_t status; -- 2.25.1
The patch LGTM. With the Fixes tag added: Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization