Re: [PATCH 3/9] drm/format-helper: Add destination-buffer pitch to drm_fb_swab()
From: Noralf Trønnes <hidden>
Date: 2021-10-24 08:33:26
Also in:
dri-devel, linux-hyperv
Den 22.10.2021 15.28, skrev Thomas Zimmermann:
quoted hunk ↗ jump to hunk
Add destination-buffer pitch as argument to drm_fb_swab(). Done for consistency with the rest of the interface. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/drm_format_helper.c | 19 +++++++++++++++---- drivers/gpu/drm/drm_mipi_dbi.c | 2 +- drivers/gpu/drm/gud/gud_pipe.c | 2 +- include/drm/drm_format_helper.h | 5 +++-- 4 files changed, 20 insertions(+), 8 deletions(-)diff --git a/drivers/gpu/drm/drm_format_helper.c b/drivers/gpu/drm/drm_format_helper.c index 38c8055f6fa8..79869ed553d9 100644 --- a/drivers/gpu/drm/drm_format_helper.c +++ b/drivers/gpu/drm/drm_format_helper.c@@ -92,6 +92,7 @@ EXPORT_SYMBOL(drm_fb_memcpy_toio); /** * drm_fb_swab - Swap bytes into clip buffer * @dst: Destination buffer + * @dst_pitch: Number of bytes between two consecutive scanlines within dst * @src: Source buffer * @fb: DRM framebuffer * @clip: Clip rectangle area to copy@@ -103,19 +104,25 @@ EXPORT_SYMBOL(drm_fb_memcpy_toio); * This function does not apply clipping on dst, i.e. the destination
You have changed this line on the other functions, maybe you just missed it here:
* is a small buffer containing the clip rect only. */ -void drm_fb_swab(void *dst, void *src, struct drm_framebuffer *fb, - struct drm_rect *clip, bool cached) +void drm_fb_swab(void *dst, unsigned int dst_pitch, const void *src, + const struct drm_framebuffer *fb, const struct drm_rect *clip, + bool cached)
Tested-by: Noralf Trønnes <redacted> Reviewed-by: Noralf Trønnes <redacted> _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization