Re: [PATCH] vhost: Make use of the helper macro kthread_run()
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2021-10-27 20:02:19
Also in:
kvm, lkml, netdev
On Thu, Oct 21, 2021 at 04:44:06PM +0800, Cai Huoqing wrote:
Repalce kthread_create/wake_up_process() with kthread_run() to simplify the code. Signed-off-by: Cai Huoqing <redacted>
Pls check how this interacts with Mike Christie's patches. Pls fix up the typo in the commit log.
quoted hunk ↗ jump to hunk
--- drivers/vhost/vhost.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 59edb5a1ffe2..e67bd5603b5f 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c@@ -595,15 +595,15 @@ long vhost_dev_set_owner(struct vhost_dev *dev) dev->kcov_handle = kcov_common_handle(); if (dev->use_worker) { - worker = kthread_create(vhost_worker, dev, - "vhost-%d", current->pid); + /* avoid contributing to loadavg */
doesn't this comment have any value anymore?
+ worker = kthread_run(vhost_worker, dev,
+ "vhost-%d", current->pid);
if (IS_ERR(worker)) {
err = PTR_ERR(worker);
goto err_worker;
}
dev->worker = worker;
- wake_up_process(worker); /* avoid contributing to loadavg */
err = vhost_attach_cgroups(dev);
if (err)
--
2.25.1_______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization