Thread (1 message) 1 message, 1 author, 2021-10-27

Re: [PATCH -next] virtio-pci: fix error return code in vp_legacy_probe()

From: Jason Wang <hidden>
Date: 2021-10-27 02:37:35
Also in: lkml

On Tue, Oct 26, 2021 at 9:39 PM Yang Yingliang [off-list ref] wrote:
Return error code if pci_iomap() fails in vp_legacy_probe()

Reported-by: Hulk Robot <redacted>
Fixes: c3ca8a3eeb54 ("virtio-pci: introduce legacy device module")
Signed-off-by: Yang Yingliang <redacted>
---
Acked-by: Jason Wang <redacted>
quoted hunk
 drivers/virtio/virtio_pci_legacy_dev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_pci_legacy_dev.c b/drivers/virtio/virtio_pci_legacy_dev.c
index 9b97680dd02b..4ca3ef38d3bf 100644
--- a/drivers/virtio/virtio_pci_legacy_dev.c
+++ b/drivers/virtio/virtio_pci_legacy_dev.c
@@ -45,8 +45,10 @@ int vp_legacy_probe(struct virtio_pci_legacy_device *ldev)
                return rc;

        ldev->ioaddr = pci_iomap(pci_dev, 0, 0);
-       if (!ldev->ioaddr)
+       if (!ldev->ioaddr) {
+               rc = -ENOMEM;
                goto err_iomap;
+       }

        ldev->isr = ldev->ioaddr + VIRTIO_PCI_ISR;

--
2.25.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help