Re: [PATCH] gpio: aggregator: Add interrupt support
From: Andy Shevchenko <hidden>
Date: 2021-10-04 13:49:16
Also in:
linux-gpio, linux-renesas-soc, lkml
On Mon, Oct 4, 2021 at 3:45 PM Geert Uytterhoeven [off-list ref] wrote:
Currently the GPIO Aggregator does not support interrupts. This means that kernel drivers going from a GPIO to an IRQ using gpiod_to_irq(), and userspace applications using line events do not work. Add interrupt support by providing a gpio_chip.to_irq() callback, which just calls into the parent GPIO controller. Note that this does not implement full interrupt controller (irq_chip) support, so using e.g. gpio-keys with "interrupts" instead of "gpios" still does not work.
...
quoted hunk ↗ jump to hunk
@@ -414,7 +421,8 @@ static struct gpiochip_fwd *gpiochip_fwd_create(struct device *dev, for (i = 0; i < ngpios; i++) { struct gpio_chip *parent = gpiod_to_chip(descs[i]); - dev_dbg(dev, "%u => gpio-%d\n", i, desc_to_gpio(descs[i])); + dev_dbg(dev, "%u => gpio %d irq %d\n", i, + desc_to_gpio(descs[i]), gpiod_to_irq(descs[i]));
This is an unconditional call that will allocate the IRQ descriptor even if we don't use it. Correct? If so, I don't like this. -- With Best Regards, Andy Shevchenko _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization