Re: [PATCH 1/1] virtio-blk: remove unneeded "likely" statements
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2021-09-03 09:04:54
Also in:
kvm, linux-block
On Thu, Sep 02, 2021 at 10:13:04PM +0300, Max Gurtovoy wrote:
On 9/2/2021 6:00 PM, Stefan Hajnoczi wrote:quoted
On Mon, Aug 30, 2021 at 03:01:11PM +0300, Max Gurtovoy wrote:quoted
Usually we use "likely/unlikely" to optimize the fast path. Remove redundant "likely" statements in the control path to ease on the code. Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> --- drivers/block/virtio_blk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)It would be nice to tweak the commit description before merging this. I had trouble parsing the second sentence. If I understand correctly the purpose of this patch is to make the code simpler and easier to read: s/ease on the code/simplify the code and make it easier to read/I'm ok with this change in commit message. MST, can you apply this change if you'll pick this commit ? -Max.
Just repost with a fixed commit log pls, easier for me. Thanks!
quoted
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
_______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization