Thread (1 message) flat view 1 message, 1 author, 2021-09-08

Re: [PATCH 1/2] fuse: disable atomic_o_trunc if no_open is enabled

From: JeffleXu <jefflexu@linux.alibaba.com>
Date: 2021-09-08 09:42:05
Also in: linux-fsdevel


On 9/7/21 4:34 PM, Miklos Szeredi wrote:
On Thu, 12 Aug 2021 at 07:46, Jeffle Xu [off-list ref] wrote:
quoted
From: Liu Bo <redacted>

When 'no_open' is used by virtiofsd, guest kernel won't send OPEN request
any more.  However, with atomic_o_trunc, SETATTR request is also omitted in
OPEN(O_TRUNC) so that the backend file is not truncated.  With a following
GETATTR, inode size on guest side is updated to be same with that on host
side, the end result is that O_TRUNC semantic is broken.

This disables atomic_o_trunc as well if with no_open.
I don't quite get it why one would want to enable atomic_o_trunc with
no_open in the first place?
Oops..We didn't realize that it could also be worked around by fuse
daemon side. Please ignore this.

-- 
Thanks,
Jeffle
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help