Re: [PATCH v2 1/6] driver core: Move the "authorized" attribute from USB/Thunderbolt to core
From: Alan Stern <stern@rowland.harvard.edu>
Date: 2021-09-30 01:42:33
Also in:
linux-pci, linux-usb, lkml
On Wed, Sep 29, 2021 at 06:05:06PM -0700, Kuppuswamy Sathyanarayanan wrote:
Currently bus drivers like "USB" or "Thunderbolt" implement a custom version of device authorization to selectively authorize the driver probes. Since there is a common requirement, move the "authorized" attribute support to the driver core in order to allow it to be used by other subsystems / buses. Similar requirements have been discussed in the PCI [1] community for PCI bus drivers as well. No functional changes are intended. It just converts authorized attribute from int to bool and moves it to the driver core. There should be no user-visible change in the location or semantics of attributes for USB devices. Regarding thunderbolt driver, although it declares sw->authorized as "int" and allows 0,1,2 as valid values for sw->authorized attribute, but within the driver, in all authorized attribute related checks, it is treated as bool value. So when converting the authorized attribute from int to bool value, there should be no functional changes other than value 2 being not visible to the user. [1]: https://lore.kernel.org/all/CACK8Z6E8pjVeC934oFgr=VB3pULx_GyT2NkzAogdRQJ9TKSX9A@mail.gmail.com/ (local) Reviewed-by: Dan Williams <redacted> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Since you're moving the authorized flag from the USB core to the driver core, the corresponding sysfs attribute functions should be moved as well. Also, you ignored the usb_[de]authorize_interface() functions and their friends. Alan Stern _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization