Re: [PATCH v3 7/7] eni_vdpa: add vDPA driver for Alibaba ENI

From
Jason Wang <hidden>
Date
2021-09-28 02:17:21
Also in
lkml
Reply to
Michael S. Tsirkin, 2021-09-27
On Mon, Sep 27, 2021 at 6:36 PM Michael S. Tsirkin [off-list ref] wrote:
On Sun, Sep 26, 2021 at 12:18:26PM +0800, Jason Wang wrote:
quoted
quoted
quoted
I wonder if the following can work with ENI:

-device virtio-net-pci,mrg_rxbuf=off

?
ENI didn't work.
I will remove F_MRG_RXBUF when get_features.
I think we need to fail FEATURE_OK if F_MRG_RXBUF is not negotiated.
Since VERSION_1 requires a fixed header length even if F_MRG_RXBUF is
not negotiated.

But this trick doesn't come for free. If some driver doesn't support
mrg_rxbuf, it won't work.

Thanks
Yea. Ugh. Down the road I think we'll add legacy support to vdpa on
strongly ordered systems.
I don't see the connection, can you explain why?
Doing it in userspace is just too messy imho.
But yes, this kind of hack is probably ok for weakly ordered systems.
BTW we need to set VIRTIO_F_ORDER_PLATFORM, right?
Right.

Thanks
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Thread (3 messages) 3 messages, 2 authors, last reply 2021-09-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help