Re: [PATCH v8 2/3] tty: hvc: pass DMA capable memory to put_chars()
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2021-08-20 12:34:13
Also in:
linuxppc-dev, lkml
Daniel Axtens [off-list ref] writes:
Xianting Tian [off-list ref] writes:quoted
As well known, hvc backend driver(eg, virtio-console) can register its operations to hvc framework. The operations can contain put_chars(), get_chars() and so on. Some hvc backend may do dma in its operations. eg, put_chars() of virtio-console. But in the code of hvc framework, it may pass DMA incapable memory to put_chars() under a specific configuration, which is explained in commit c4baad5029(virtio-console: avoid DMA from stack):We could also run into issues on powerpc where Andrew is working on adding vmap-stack but the opal hvc driver assumes that it is passed a buffer which is not in vmalloc space but in the linear mapping.
The right fix for that is our code that calls opal has to be careful that it's not passing vmalloc addresses. We have many cases where we pass stack variables to opal, they'll all have to be fixed to pass the underlying phyiscal/linear map address. The opal hvc code will just be one more case of that. cheers _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization