Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO

在 2021/8/12 上午6:17, Jakub Kicinski 写道:

On Wed, 11 Aug 2021 16:16:23 +0800 Jason Wang wrote:

quoted

Try to fix this by using NETIF_F_GRO_HW instead so we're not
guaranteed to be re-segmented as original.

This sentence may need rephrasing.

Right, actually, I meant:


Try to fix this by using NETIF_F_GRO_HW instead. But we're not sure the 
packet could be re-segmented to the exact original packet stream. Since 
it's really depends on the bakcend implementation.

quoted

Or we may want a new netdev
feature like RX_GSO since the guest offloads for virtio-net is
actually to receive GSO packet.

Or we can try not advertise LRO is control guest offloads is not
enabled. This solves the warning but will still slow down the traffic.

IMO gro-hw fits pretty well, patch looks good.

If the re-segmentation is not a issue. I will post a formal patch.

Thanks

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization