Re: [PATCH 1/4] VSOCK DRIVER: Add multi-cid support for guest
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2021-08-02 20:12:08
Also in:
kvm, lkml, netdev
On Mon, Aug 02, 2021 at 08:07:17PM +0800, fuguancheng wrote:
quoted hunk
diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h index 3dd3555b2740..0afc14446b01 100644 --- a/include/uapi/linux/virtio_vsock.h +++ b/include/uapi/linux/virtio_vsock.h@@ -42,7 +42,8 @@ #define VIRTIO_VSOCK_F_SEQPACKET 1 /* SOCK_SEQPACKET supported */ struct virtio_vsock_config { - __le64 guest_cid; + __le32 number_cid; + __le64 cids[]; } __attribute__((packed));
any host/guest interface change needs to copy the virtio TC. packing here is a bad idea imho, just add explicit padding. -- MST _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization