Thread (10 messages) 10 messages, 5 authors, 2021-07-08

Re: [PATCH V2 5/6] virtio: add one field into virtio_device for recording if device uses managed irq

From: Thomas Gleixner <hidden>
Date: 2021-07-07 09:06:34
Also in: linux-block, linux-nvme, linux-scsi

On Tue, Jul 06 2021 at 07:42, Christoph Hellwig wrote:
On Fri, Jul 02, 2021 at 11:05:54PM +0800, Ming Lei wrote:
quoted
blk-mq needs to know if the device uses managed irq, so add one field
to virtio_device for recording if device uses managed irq.

If the driver use managed irq, this flag has to be set so it can be
passed to blk-mq.
I don't think all this boilerplate code make a whole lot of sense.
I think we need to record this information deep down in the irq code by
setting a flag in struct device only if pci_alloc_irq_vectors_affinity
atually managed to allocate multiple vectors and the PCI_IRQ_AFFINITY
flag was set.  Then blk-mq can look at that flag, and also check that
more than one queue is in used and work based on that.
Ack.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help