V Vivek Goyal #
Message details and related content
On Fri, Jul 16, 2021 at 08:40:29AM +0800, Liu Bo wrote:
On Thu, Jul 15, 2021 at 05:30:31PM +0800, Jeffle Xu wrote:quoted
Add one flag for fuse_attr.flags indicating if DAX shall be enabled for this file. When the per-file DAX flag changes for an *opened* file, the state of the file won't be updated until this file is closed and reopened later. Currently it is not implemented yet to change per-file DAX flag inside guest kernel, e.g., by chattr(1).Thanks for the patch, it looks good to me. I think it's a good starting point, what I'd like to discuss here is whether we're going to let chattr to toggle the dax flag.
I have the same question. Why not take chattr approach as taken
by ext4/xfs as well.
Vivek
My usecase is like, on the fuse server side, if a file is marked as DAX, then it won't change any more. So this 'fuse_attr.flags' works for me at least. thanks, liuboquoted
Signed-off-by: Jeffle Xu <redacted> --- fs/fuse/dax.c | 28 ++++++++++++++++++++++++---- fs/fuse/file.c | 4 ++-- fs/fuse/fuse_i.h | 5 +++-- fs/fuse/inode.c | 4 +++- include/uapi/linux/fuse.h | 5 +++++ 5 files changed, 37 insertions(+), 9 deletions(-)diff --git a/fs/fuse/dax.c b/fs/fuse/dax.c index 4873d764cb66..ed5a430364bb 100644 --- a/fs/fuse/dax.c +++ b/fs/fuse/dax.c@@ -1341,7 +1341,7 @@ static const struct address_space_operations fuse_dax_file_aops = { .invalidatepage = noop_invalidatepage, }; -static bool fuse_should_enable_dax(struct inode *inode) +static bool fuse_should_enable_dax(struct inode *inode, unsigned int flags) { struct fuse_conn *fc = get_fuse_conn(inode); unsigned int mode;@@ -1354,18 +1354,38 @@ static bool fuse_should_enable_dax(struct inode *inode) if (mode == FUSE_DAX_MOUNT_NEVER) return false; - return true; + if (mode == FUSE_DAX_MOUNT_ALWAYS) + return true; + + WARN_ON(mode != FUSE_DAX_MOUNT_INODE);
_______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization