On 2021/7/23 17:03, Arnd Bergmann wrote:

On Fri, Jul 23, 2021 at 7:44 AM Jie Deng [off-list ref] wrote:

quoted

+
+       ret = virtio_i2c_setup_vqs(vi);
+       if (ret)
+               return ret;
+
+       vi->adap.owner = THIS_MODULE;
+       snprintf(vi->adap.name, sizeof(vi->adap.name),
+                "i2c_virtio at virtio bus %d", vdev->index);
+       vi->adap.algo = &virtio_algorithm;
+       vi->adap.quirks = &virtio_i2c_quirks;
+       vi->adap.dev.parent = &vdev->dev;
+       i2c_set_adapdata(&vi->adap, vi);
+
+       /*
+        * Setup ACPI node for controlled devices which will be probed through
+        * ACPI.
+        */
+       ACPI_COMPANION_SET(&vi->adap.dev, ACPI_COMPANION(pdev));

Since there is now a generic way for virtio drivers to link up with OF
device nodes, maybe this should be handled the same way in the
virtio core rather than the driver?

I'm currently based on the I2C tree. Has that patch been already merged ？

Anyway, I think we can send an additional patch to remove this line once 
that

"generic way" patch is merged.

Regards,

Jie



_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization