Thread (1 message) 1 message, 1 author, 2021-07-26

Re: [PATCH V3 2/5] dt-bindings: i2c: Add bindings for i2c-virtio

From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2021-07-26 09:21:07
Also in: linux-devicetree, linux-i2c, lkml

On 26-07-21, 10:11, Arnd Bergmann wrote:
On Mon, Jul 26, 2021 at 10:06 AM Arnd Bergmann [off-list ref] wrote:
quoted
On Mon, Jul 26, 2021 at 6:52 AM Viresh Kumar [off-list ref] wrote:
quoted
This patch adds binding for virtio I2C device, it is based on
virtio-device bindings.

Acked-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Too quick, after seeing the same issue in the gpio binding I saw it here too:
quoted
+        i2c-virtio {
+            compatible = "virtio,22";
The node name "i2c-virtio" looks wrong. According to
https://github.com/devicetree-org/dt-schema/blob/master/schemas/i2c/i2c-controller.yaml,
this needs to be plain "i2c".
Okay, I will move back to simple node names then.

Thanks.

-- 
viresh
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help