Re: [PATCH 1/2] vhost-vdpa: Fix integer overflow in vhost_vdpa_process_iotlb_update()
From: Jason Wang <hidden>
Date: 2021-07-19 03:30:24
Also in:
kvm, lkml
在 2021/7/16 下午6:22, Xie Yongji 写道:
The "msg->iova + msg->size" addition can have an integer overflow
if the iotlb message is from a malicious user space application.
So let's fix it.
Fixes: 1b48dc03e575 ("vhost: vdpa: report iova range")
Reported-by: Dan Carpenter <redacted>
Signed-off-by: Xie Yongji <redacted>Acked-by: Jason Wang <redacted>
quoted hunk
--- drivers/vhost/vdpa.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 210ab35a7ebf..8e3c8790d493 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c@@ -615,6 +615,7 @@ static int vhost_vdpa_process_iotlb_update(struct vhost_vdpa *v, int ret = 0; if (msg->iova < v->range.first || + msg->iova - 1 > U64_MAX - msg->size || msg->iova + msg->size - 1 > v->range.last) return -EINVAL;
_______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization