Re: virtio-net: kernel panic in virtio_net.c

On Wed, 9 Jun 2021 10:03:53 +0200, Greg KH [off-list ref] wrote:

On Wed, Jun 09, 2021 at 03:51:20PM +0800, Xuan Zhuo wrote:

quoted

On Wed, 9 Jun 2021 08:24:20 +0200, Greg KH [off-list ref] wrote:

quoted

On Wed, Jun 09, 2021 at 02:08:17PM +0800, Xuan Zhuo wrote:

quoted

On Wed, 9 Jun 2021 06:50:10 +0200, Greg KH [off-list ref] wrote:

quoted

On Wed, Jun 09, 2021 at 09:48:33AM +0800, Xuan Zhuo wrote:

quoted

quoted

quoted

With this patch and the latest net branch I no longer get crashes.

Did this ever get properly submitted to the networking tree to get into
5.13-final?

The patch has been submitted.

	[PATCH net] virtio-net: fix for skb_over_panic inside big mode

Submitted where?  Do you have a lore.kernel.org link somewhere?

https://lore.kernel.org/netdev/20210603170901.66504-1-xuanzhuo@linux.alibaba.com/ (local)

So this is commit 1a8024239dac ("virtio-net: fix for skb_over_panic
inside big mode") in Linus's tree, right?

YES.

quoted

But why is that referencing:
	Fixes: fb32856b16ad ("virtio-net: page_to_skb() use build_skb when there's sufficient tailroom")

This problem was indeed introduced in fb32856b16ad.

I confirmed that this commit fb32856b16ad was first entered in 5.13-rc1, and the
previous 5.12 did not have this commit fb32856b16ad.

I'm not sure if it helped you.

Hm, then what resolves the reported problem that people were having with
the 5.12.y kernel release?  Is that a separate issue?

Has anyone reported a problem with 5.12.y? I don’t seem to see it. Corentin
only reported a problem with 5.13? Did I miss something?

I confirm that 5.12.9 has no modification of fb32856b16ad.

Thanks.

thanks,

greg k-h

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization