Re: [RFC PATCH v1 07/16] virtio/vsock: don't count EORs on receive

Started by Stefano Garzarella on Jun 30, 2021

open the first message on its own page

Message details and related content
On Mon, Jun 28, 2021 at 01:03:15PM +0300, Arseny Krasnov wrote:
quoted hunk
There is no sense to count EORs, because 'rx_bytes' is
used to check data presence on socket.

Signed-off-by: Arseny Krasnov <redacted>
---
net/vmw_vsock/virtio_transport_common.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
index 84431d7a87a5..319c3345f3e0 100644
--- a/net/vmw_vsock/virtio_transport_common.c
+++ b/net/vmw_vsock/virtio_transport_common.c
@@ -1005,9 +1005,6 @@ virtio_transport_recv_enqueue(struct vsock_sock *vsk,
              goto out;
      }

-      if (le32_to_cpu(pkt->hdr.flags) & VIRTIO_VSOCK_SEQ_EOR)
-              vvs->msg_count++;
-
Same here, please remove it when you don't need it, and also remove from
the struct virtio_vsock_sock.

Thanks,
Stefano
      /* Try to copy small packets into the buffer of last packet queued,
       * to avoid wasting memory queueing the entire buffer with a small
       * payload.
--
2.25.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help