Thread (2 messages) flat view 2 messages, 1 author, 2021-06-03

Re: [PATCH] vdpa/mlx5: Clear vq ready indication upon device reset

From: Jason Wang <hidden>
Date: 2021-06-03 07:00:25
Also in: lkml

在 2021/6/2 下午4:59, Eli Cohen 写道:
After device reset, the virtqueues are not ready so clear the ready
field.

Failing to do so can result in virtio_vdpa failing to load if the device
was previously used by vhost_vdpa and the old values are ready.
virtio_vdpa expects to find VQs in "not ready" state.

Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Eli Cohen <redacted>

Acked-by: Jason Wang <redacted>

quoted hunk
---
  drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 +
  1 file changed, 1 insertion(+)
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index 02a05492204c..e8bc0842b44c 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -862,6 +862,7 @@ static void destroy_virtqueue(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtq
  		return;
  	}
  	umems_destroy(ndev, mvq);
+	mvq->ready = false;
  }
  
  static u32 get_rqpn(struct mlx5_vdpa_virtqueue *mvq, bool fw)
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help