Re: [PATCH 1/3] virtio: update reset callback to return status
From: Cornelia Huck <cohuck@redhat.com>
Date: 2021-04-07 13:45:00
Also in:
kvm
On Wed, 7 Apr 2021 12:09:22 +0000 Max Gurtovoy [off-list ref] wrote:
The reset device operation, usually is an operation that might fail from various reasons. For example, the controller might be in a bad state and can't answer to any request. Usually, the paravirt SW based virtio devices always succeed in reset operation but this is not the case for HW based virtio devices. This commit is also a preparation for adding a timeout mechanism for resetting virtio devices. Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> --- drivers/remoteproc/remoteproc_virtio.c | 3 ++- drivers/virtio/virtio.c | 22 +++++++++++++++------- drivers/virtio/virtio_mmio.c | 3 ++- drivers/virtio/virtio_pci_legacy.c | 3 ++- drivers/virtio/virtio_pci_modern.c | 3 ++- drivers/virtio/virtio_vdpa.c | 3 ++- include/linux/virtio_config.h | 5 +++-- 7 files changed, 28 insertions(+), 14 deletions(-)
You missed drivers/s390/virtio/virtio_ccw.c. virtio_ccw_reset() should probably return -ENOMEM on allocation failure and forward the return code of ccw_io_helper(). _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization