Thread (22 messages) 22 messages, 3 authors, 2021-04-12

Re: [PATCH v4 10/14] vhost/vdpa: Remove the restriction that only supports virtio-net devices

From: Jason Wang <jasowang@redhat.com>
Date: 2021-03-18 03:25:20
Also in: kvm, lkml, netdev

在 2021/3/16 上午12:34, Stefano Garzarella 写道:
From: Xie Yongji <redacted>

Since the config checks are done by the vDPA drivers, we can remove the
virtio-net restriction and we should be able to support all kinds of
virtio devices.

<linux/virtio_net.h> is not needed anymore, but we need to include
<linux/slab.h> to avoid compilation failures.

Signed-off-by: Xie Yongji <redacted>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>

Acked-by: Jason Wang <jasowang@redhat.com>

quoted hunk ↗ jump to hunk
---
  drivers/vhost/vdpa.c | 6 +-----
  1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index 7ae4080e57d8..850ed4b62942 100644
--- a/drivers/vhost/vdpa.c
+++ b/drivers/vhost/vdpa.c
@@ -16,12 +16,12 @@
  #include <linux/cdev.h>
  #include <linux/device.h>
  #include <linux/mm.h>
+#include <linux/slab.h>
  #include <linux/iommu.h>
  #include <linux/uuid.h>
  #include <linux/vdpa.h>
  #include <linux/nospec.h>
  #include <linux/vhost.h>
-#include <linux/virtio_net.h>
  
  #include "vhost.h"
  
@@ -1018,10 +1018,6 @@ static int vhost_vdpa_probe(struct vdpa_device *vdpa)
  	int minor;
  	int r;
  
-	/* Currently, we only accept the network devices. */
-	if (ops->get_device_id(vdpa) != VIRTIO_ID_NET)
-		return -ENOTSUPP;
-
  	v = kzalloc(sizeof(*v), GFP_KERNEL | __GFP_RETRY_MAYFAIL);
  	if (!v)
  		return -ENOMEM;
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help