Thread (1 message) flat view 1 message, 1 author, 2021-02-05

Re: [PATCH 05/11] vhost scsi: use lio wq cmd submission helper

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2021-02-05 22:14:04
Also in: linux-scsi, target-devel

On Thu, Feb 04, 2021 at 05:35:07AM -0600, Mike Christie wrote:
quoted hunk
@@ -1132,14 +1127,8 @@ vhost_scsi_handle_vq(struct vhost_scsi *vs, struct vhost_virtqueue *vq)
 		 * vhost_scsi_queue_data_in() and vhost_scsi_queue_status()
 		 */
 		cmd->tvc_vq_desc = vc.head;
-		/*
-		 * Dispatch cmd descriptor for cmwq execution in process
-		 * context provided by vhost_scsi_workqueue.  This also ensures
-		 * cmd is executed on the same kworker CPU as this vhost
-		 * thread to gain positive L2 cache locality effects.
-		 */
-		INIT_WORK(&cmd->work, vhost_scsi_submission_work);
-		queue_work(vhost_scsi_workqueue, &cmd->work);
+		target_queue_cmd_submit(tpg->tpg_nexus->tvn_se_sess,
+					&cmd->tvc_se_cmd);
 		ret = 0;
 err:
 		/*
What about this aspect? Will things still stay on the same CPU?

-- 
MST

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help