Thread (27 messages) 27 messages, 4 authors, 2021-02-08

Re: [PATCH v3 03/13] vringh: reset kiov 'consumed' field in __vringh_iov()

From: Jason Wang <jasowang@redhat.com>
Date: 2021-02-05 03:19:52
Also in: kvm, lkml

On 2021/2/5 上午1:22, Stefano Garzarella wrote:
__vringh_iov() overwrites the contents of riov and wiov, in fact it
resets the 'i' and 'used' fields, but also the 'consumed' field should
be reset to avoid an inconsistent state.

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
  drivers/vhost/vringh.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Jason Wang <jasowang@redhat.com>

quoted hunk ↗ jump to hunk
diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
index f68122705719..bee63d68201a 100644
--- a/drivers/vhost/vringh.c
+++ b/drivers/vhost/vringh.c
@@ -290,9 +290,9 @@ __vringh_iov(struct vringh *vrh, u16 i,
  		return -EINVAL;
  
  	if (riov)
-		riov->i = riov->used = 0;
+		riov->i = riov->used = riov->consumed = 0;
  	if (wiov)
-		wiov->i = wiov->used = 0;
+		wiov->i = wiov->used = wiov->consumed = 0;
  
  	for (;;) {
  		void *addr;
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help