Re: [RFC 08/10] vhost: Add x-vhost-enable-shadow-vq qmp

Eugenio Perez Martin [off-list ref] writes:

On Tue, Feb 2, 2021 at 4:38 PM Eric Blake [off-list ref] wrote:

quoted

On 1/29/21 2:54 PM, Eugenio Pérez wrote:

[...]

quoted

quoted

diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 040f68ff2e..42836e45f3 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c

@@ -15,6 +15,7 @@

 #include "qemu/osdep.h"
 #include "qapi/error.h"
+#include "qapi/qapi-commands-net.h"
 #include "hw/virtio/vhost.h"
 #include "qemu/atomic.h"
 #include "qemu/range.h"

@@ -1841,3 +1842,8 @@ int vhost_net_set_backend(struct vhost_dev *hdev,

     return -1;
 }
+
+void qmp_x_vhost_enable_shadow_vq(const char *name, bool enable, Error **errp)
+{
+    error_setg(errp, "Shadow virtqueue still not implemented.");

error_setg() should not be passed a trailing '.'.

Oh, sorry I missed the comment in the error_setg doc.

I copy&pasted from the call to error_setg "Migration disabled: vhost
lacks VHOST_F_LOG_ALL feature.". I'm wondering if it's a good moment
to delete the dot there too, since other tools could depend on parsing
it.

It's pretty much always a good moment for patches improving error
messages :)

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization