Thread (7 messages) 7 messages, 3 authors, 2021-01-25

Re: [PATCH V2 2/2] block: remove unnecessary argument from blk_execute_rq

From: Ulf Hansson <hidden>
Date: 2021-01-22 10:01:57
Also in: linux-block, linux-ide, linux-mmc, linux-nfs, linux-nvme, linux-scsi, target-devel

On Fri, 22 Jan 2021 at 10:28, Guoqing Jiang
[off-list ref] wrote:
We can remove 'q' from blk_execute_rq as well after the previous change
in blk_execute_rq_nowait.

And more importantly it never really was needed to start with given
that we can trivial derive it from struct request.

Cc: linux-scsi@vger.kernel.org
Cc: virtualization@lists.linux-foundation.org
Cc: linux-ide@vger.kernel.org
Cc: linux-mmc@vger.kernel.org
Cc: linux-nvme@lists.infradead.org
Cc: linux-nfs@vger.kernel.org
Signed-off-by: Guoqing Jiang <redacted>
[...]
 drivers/mmc/core/block.c          | 10 +++++-----
[...]

From mmc point of view, please add:

Acked-by: Ulf Hansson <redacted>

At the moment I don't think this will conflict with any changes to
mmc, but if that happens let's sort it then...

Kind regards
Uffe
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help